Status: Done (View workflow)
the calucation of the crAdjustemtns is wrong (except two case). The problem resides in com.trollworks.gcs.advantage.SelfControlRollAdjustments.java (Version 4.9.0 for Linux, but I think, it wouldn't be different with Windows or Mac)
The problem are the methods "public int getAdjustment(SelfControlRoll cr)" in every case except "NONE" and "MAJOR_COST_OF_LIVING_INCREASE". The problem is, that the result is one to big (in case of a penalty) oder one to small (in case of a bonus).
For example the Loner Disadvantage (B142) should have the following reaction penalties:
CR 6: -4
CR 9: -3
CR 12: -2
CR 15: -1
but GCS says, that every penalty is one point higher (CR6 has -3 and CR15 0).
Additional: The Merchant penalty in "MAJOR_COST_OF_LIVING_INCREASE" is also incorrect (same problem) (calculate in MAJOR_COST_OF_LIVING_INCREASE.getBonuses(SelfControlRoll cr)).
Solution: It is only necessary to change the number 4 to 5 in every method, which has this problem.
For example in REACTION_PENALTY the line
return cr.ordinal() - 4;
only needs to be changed to
return cr.ordinal() - 5;